RGB led library migration

include/led.h

@@ -1,9 +1,11 @@
 #ifndef _LED_H
 #define _LED_H
 
-#ifdef RGB_LED_COUNT
+#ifdef HAS_RGB_LED
-#include <SmartLeds.h>
+#include <FastLED.h>
+#include "libpax_helpers.h"
 #endif
+
 #ifdef HAS_LORA
 #include "lorawan.h"
 #endif
@@ -12,39 +14,14 @@
 #define RGB_LED_COUNT 1
 #endif
 
-// value for HSL color
-// see http://www.workwithcolor.com/blue-color-hue-range-01.htm
-#define COLOR_RED 0
-#define COLOR_ORANGE 30
-#define COLOR_ORANGE_YELLOW 45
-#define COLOR_YELLOW 60
-#define COLOR_YELLOW_GREEN 90
-#define COLOR_GREEN 120
-#define COLOR_GREEN_CYAN 165
-#define COLOR_CYAN 180
-#define COLOR_CYAN_BLUE 210
-#define COLOR_BLUE 240
-#define COLOR_BLUE_MAGENTA 275
-#define COLOR_MAGENTA 300
-#define COLOR_PINK 350
-#define COLOR_WHITE 360
-#define COLOR_NONE 999
-
-struct RGBColor {
-  uint8_t R;
-  uint8_t G;
-  uint8_t B;
-};
-
 enum led_states { LED_OFF, LED_ON };
 
 extern TaskHandle_t ledLoopTask;
 
-// Exported Functions
+void rgb_led_init(void);
-void rgb_set_color(uint16_t hue);
+void led_sethue(uint8_t hue);
-void blink_LED(uint16_t set_color, uint16_t set_blinkduration);
 void ledLoop(void *parameter);
-void switch_LED(uint8_t state);
+void switch_LED(led_states state);
-void switch_LED1(uint8_t state);
+void switch_LED1(led_states state);
 
 #endif

platformio_orig.ini

@@ -67,7 +67,7 @@ lib_deps_display =
 lib_deps_ledmatrix =
     seeed-studio/Ultrathin_LED_Matrix @ ^1.0.0
 lib_deps_rgbled =
-    https://github.com/RoboticsBrno/SmartLeds.git
+    fastled/FastLED @ ^3.5.0
 lib_deps_gps =
     mikalhart/TinyGPSPlus @ ^1.0.3
 lib_deps_sensors =

src/hal/eboxtube.h

@@ -15,7 +15,7 @@
 
 #define HAS_LED (22)     // Green LED on board
 #define RGB_LED_COUNT 1 // we have 1 LED
-#define HAS_RGB_LED SmartLed rgb_led(LED_WS2812, RGB_LED_COUNT, GPIO_NUM_2) // WS2812B RGB LED on board
+#define HAS_RGB_LED FastLED.addLeds<WS2812, GPIO_NUM_2, GRB>(leds, RGB_LED_COUNT);
 #define HAS_BUTTON (0)   // button "FLASH" on board
 #define DISABLE_BROWNOUT 1      // comment out if you want to keep brownout feature
 

src/hal/fipy.h

@@ -13,7 +13,8 @@
 
 #define CFG_sx1272_radio 1
 #define HAS_LED NOT_A_PIN      // FiPy has no on board LED, so we use RGB LED
-#define HAS_RGB_LED SmartLed rgb_led(LED_WS2812, 1, GPIO_NUM_0) // WS2812B RGB LED on GPIO0
+#define RGB_LED_COUNT 1 // we have 1 LED
+#define HAS_RGB_LED FastLED.addLeds<WS2812, GPIO_NUM_0, GRB>(leds, RGB_LED_COUNT);
 #define BOARD_HAS_PSRAM        // use extra 4MB extern RAM
 
 // Pins for LORA chip SPI interface, reset line and interrupt lines

src/hal/generic.h

@@ -72,7 +72,8 @@
 
 #define HAS_LED (21) // on board  LED
 #define HAS_BUTTON (39) // on board button
-#define HAS_RGB_LED SmartLed rgb_led(LED_WS2812, 1, GPIO_NUM_0) // WS2812B RGB LED on GPIO0
+#define RGB_LED_COUNT 1 // we have 1 LED
+#define HAS_RGB_LED FastLED.addLeds<WS2812, GPIO_NUM_0, GRB>(leds, RGB_LED_COUNT);
 
 // GPS settings
 #define HAS_GPS 1 // use on board GPS

src/hal/lolin32litelora.h

@@ -17,7 +17,8 @@
 //#define MY_DISPLAY_FLIP  1 // uncomment this for rotated display
 #define HAS_LED       22  // ESP32 GPIO12 (pin22) On Board LED (set to NOT_A_PIN to disable)
 #define LED_ACTIVE_LOW 1  // Onboard LED is active when pin is LOW
-#define HAS_RGB_LED SmartLed rgb_led(LED_WS2812, 1, GPIO_NUM_13) // ESP32 GPIO13 (pin13) On Board Shield WS2812B RGB LED
+#define RGB_LED_COUNT 1 // we have 1 LED
+#define HAS_RGB_LED FastLED.addLeds<WS2812, GPIO_NUM_0, GRB>(leds, RGB_LED_COUNT);
 #define HAS_BUTTON    15  // ESP32 GPIO15 (pin15) Button is on the LoraNode32 shield
 #define BUTTON_PULLUP  1  // Button need pullup instead of default pulldown
 

src/hal/lolin32lora.h

@@ -18,7 +18,8 @@
 #define HAS_LED NOT_A_PIN // Led os on same pin as Lora SS pin, to avoid problems, we don't use it
 #define LED_ACTIVE_LOW 1  // Onboard LED is active when pin is LOW
                           // Anyway shield is on over the LoLin32 board, so we won't be able to see this LED
-#define HAS_RGB_LED SmartLed rgb_led(LED_WS2812, 1, GPIO_NUM_13) // ESP32 GPIO13 (pin13) On Board Shield WS2812B RGB LED
+#define RGB_LED_COUNT 1 // we have 1 LED
+#define HAS_RGB_LED FastLED.addLeds<WS2812, GPIO_NUM_13, GRB>(leds, RGB_LED_COUNT);
 #define HAS_BUTTON    15  // ESP32 GPIO15 (pin15) Button is on the LoraNode32 shield
 #define BUTTON_PULLUP  1  // Button need pullup instead of default pulldown
 

src/hal/lopy.h

@@ -12,7 +12,8 @@
 #define HAS_LORA 1       // comment out if device shall not send data via LoRa
 #define CFG_sx1272_radio 1
 #define HAS_LED NOT_A_PIN // LoPy4 has no on board mono LED, we use on board RGB LED
-#define HAS_RGB_LED SmartLed rgb_led(LED_WS2812, 1, GPIO_NUM_0) // WS2812B RGB LED on GPIO0 (P2)
+#define RGB_LED_COUNT 1 // we have 1 LED
+#define HAS_RGB_LED FastLED.addLeds<WS2812, GPIO_NUM_0, GRB>(leds, RGB_LED_COUNT);
 
 // Note: Pins for LORA chip SPI interface come from board file pins_arduino.h
 

src/hal/lopy4.h

@@ -21,7 +21,8 @@
 #define CFG_sx1276_radio 1
 #define HAS_LED NOT_A_PIN // LoPy4 has no on board mono LED, we use on board RGB LED
 #define RGB_LED_COUNT 1 // we have 1 LEDs
-#define HAS_RGB_LED SmartLed rgb_led(LED_WS2812, RGB_LED_COUNT, GPIO_NUM_0) // WS2812B RGB LED on GPIO0 (P2)
+#define RGB_LED_COUNT 1 // we have 1 LED
+#define HAS_RGB_LED FastLED.addLeds<WS2812, GPIO_NUM_0, GRB>(leds, RGB_LED_COUNT);
 #define BOARD_HAS_PSRAM // use extra 4MB extern RAM
 
 // Note: Pins for LORA chip SPI interface come from board file pins_arduino.h

src/hal/m5fire.h

@@ -33,7 +33,8 @@
 #define HAS_LED NOT_A_PIN // no on board LED (?)
 #define RGB_LED_COUNT 10
 
-#define HAS_RGB_LED SmartLed rgb_led(LED_SK6812, RGB_LED_COUNT, GPIO_NUM_15) // LED_SK6812 RGB LED on GPIO15
+#define RGB_LED_COUNT 1 // we have 1 LED
+#define HAS_RGB_LED FastLED.addLeds<SK6812, GPIO_NUM_15, GRB>(leds, RGB_LED_COUNT);
 #define HAS_BUTTON (39) // on board button A
 
 // power management settings

src/hal/octopus32.h

@@ -22,7 +22,8 @@
 
 #define HAS_LED        13  // ESP32 GPIO12 (pin22) On Board LED
 //#define LED_ACTIVE_LOW 1  // Onboard LED is active when pin is LOW
-//#define HAS_RGB_LED SmartLed rgb_led(LED_WS2812, 1, GPIO_NUM_13) // ESP32 GPIO13 (pin13) On Board Shield WS2812B RGB LED
+//#define RGB_LED_COUNT 1 // we have 1 LED
+//#define HAS_RGB_LED FastLED.addLeds<WS2812, GPIO_NUM_13, GRB>(leds, RGB_LED_COUNT);
 //#define HAS_BUTTON    15  // ESP32 GPIO15 (pin15) Button is on the LoraNode32 shield
 //#define BUTTON_PULLUP  1  // Button need pullup instead of default pulldown
 

src/led.cpp

@@ -2,142 +2,95 @@
 #include "globals.h"
 #include "led.h"
 
-led_states LEDState = LED_OFF; // LED state global for state machine
+static led_states LEDState = LED_OFF; // LED state global for state machine
-led_states previousLEDState =
-    LED_ON; // This will force LED to be off at boot since State is OFF
-
 TaskHandle_t ledLoopTask;
-
+static uint16_t LEDBlinkDuration = 0; // state machine variables
-uint16_t LEDColor = COLOR_NONE, LEDBlinkDuration = 0; // state machine variables
+static unsigned long LEDBlinkStarted =
-unsigned long LEDBlinkStarted = 0; // When (in millis() led blink started)
+    0; // When (in millis() led blink started)
 
 #ifdef HAS_RGB_LED
+CRGB leds[RGB_LED_COUNT];
 
-// RGB Led instance
+void led_setcolor(CRGB color) {
-HAS_RGB_LED;
+  for (int i = 0; i < RGB_LED_COUNT; i++)
-
+    leds[i] = color;
-float rgb_CalcColor(float p, float q, float t) {
+  FastLED.show();
-  if (t < 0.0f)
-    t += 1.0f;
-  if (t > 1.0f)
-    t -= 1.0f;
-
-  if (t < 1.0f / 6.0f)
-    return p + (q - p) * 6.0f * t;
-
-  if (t < 0.5f)
-    return q;
-
-  if (t < 2.0f / 3.0f)
-    return p + ((q - p) * (2.0f / 3.0f - t) * 6.0f);
-
-  return p;
 }
-
-// ------------------------------------------------------------------------
-// Hue, Saturation, Lightness color members
-// HslColor using H, S, L values (0.0 - 1.0)
-// L should be limited to between (0.0 - 0.5)
-// ------------------------------------------------------------------------
-RGBColor rgb_hsl2rgb(float h, float s, float l) {
-  RGBColor RGB_color;
-  float r;
-  float g;
-  float b;
-
-  if (s == 0.0f || l == 0.0f) {
-    r = g = b = l; // achromatic or black
-  } else {
-    float q = l < 0.5f ? l * (1.0f + s) : l + s - (l * s);
-    float p = 2.0f * l - q;
-    r = rgb_CalcColor(p, q, h + 1.0f / 3.0f);
-    g = rgb_CalcColor(p, q, h);
-    b = rgb_CalcColor(p, q, h - 1.0f / 3.0f);
-  }
-
-  RGB_color.R = (uint8_t)(r * 255.0f);
-  RGB_color.G = (uint8_t)(g * 255.0f);
-  RGB_color.B = (uint8_t)(b * 255.0f);
-
-  return RGB_color;
-}
-
-void rgb_set_color(uint16_t hue) {
-  if (hue == COLOR_NONE) {
-    // set Off
-    for (int i = 0; i < RGB_LED_COUNT; i++)
-      rgb_led[i] = Rgb(0, 0, 0);
-  } else {
-    // see http://www.workwithcolor.com/blue-color-hue-range-01.htm
-    // H (is color from 0..360) should be between 0.0 and 1.0
-    // S is saturation keep it to 1
-    // L is brightness should be between 0.0 and 0.5
-    // cfg.rgblum is between 0 and 100 (percent)
-    RGBColor target = rgb_hsl2rgb(hue / 360.0f, 1.0f, 0.005f * cfg.rgblum);
-    // uint32_t color = target.R<<16 | target.G<<8 | target.B;
-    for (int i = 0; i < RGB_LED_COUNT; i++)
-      rgb_led[i] = Rgb(target.R, target.G, target.B);
-  }
-  // Show
-  rgb_led.show();
-}
-
-#else
-
-// No RGB LED empty functions
-void rgb_set_color(uint16_t hue) {}
-
 #endif
 
-void switch_LED(uint8_t state) {
+void led_sethue(uint8_t hue) {
+#ifdef HAS_RGB_LED
+  for (int i = 0; i < RGB_LED_COUNT; i++)
+    leds[i] = CHSV(hue, 0XFF, 100);
+  FastLED.show();
+#endif
+}
+
+void rgb_led_init(void) {
+#ifdef HAS_RGB_LED
+  HAS_RGB_LED;
+  led_setcolor(CRGB::Green);
+#endif
+}
+
+void switch_LED(led_states state) {
+  static led_states previousLEDState = LED_OFF;
+  // led need to change state? avoid digitalWrite() for nothing
+  if (state != previousLEDState) {
+    previousLEDState = state;
 #if (HAS_LED != NOT_A_PIN)
-  if (state == LED_ON) {
+    if (state == LED_ON) {
-    // switch LED on
+      // switch LED on
 #ifdef LED_ACTIVE_LOW
-    digitalWrite(HAS_LED, LOW);
+      digitalWrite(HAS_LED, LOW);
 #else
-    digitalWrite(HAS_LED, HIGH);
+      digitalWrite(HAS_LED, HIGH);
 #endif
-  } else if (state == LED_OFF) {
+#ifdef HAS_RGB_LED
-    // switch LED off
+      led_setcolor(CRGB::White);
+#endif
+    } else if (state == LED_OFF) {
+      // switch LED off
 #ifdef LED_ACTIVE_LOW
-    digitalWrite(HAS_LED, HIGH);
+      digitalWrite(HAS_LED, HIGH);
 #else
-    digitalWrite(HAS_LED, LOW);
+      digitalWrite(HAS_LED, LOW);
+#endif
+#ifdef HAS_RGB_LED
+      led_setcolor(CRGB::Black);
+#endif
+    }
 #endif
   }
-#endif
 }
 
-void switch_LED1(uint8_t state) {
+void switch_LED1(led_states state) {
 #ifdef HAS_TWO_LED
-  if (state == LED_ON) {
+  static led_states previousLEDState = LED_OFF;
-    // switch LED on
+  // led need to change state? avoid digitalWrite() for nothing
-#ifdef LED1_ACTIVE_LOW
+  if (state != previousLEDState) {
-    digitalWrite(HAS_TWO_LED, LOW);
+    previousLEDState = state;
+#if (HAS_LED != NOT_A_PIN)
+    if (state == LED_ON) {
+      // switch LED on
+#ifdef LED_ACTIVE_LOW
+      digitalWrite(HAS_TWO_LED, LOW);
 #else
-    digitalWrite(HAS_TWO_LED, HIGH);
+      digitalWrite(HAS_TWO_LED, HIGH);
 #endif
-  } else if (state == LED_OFF) {
+    } else if (state == LED_OFF) {
-    // switch LED off
+      // switch LED off
-#ifdef LED1_ACTIVE_LOW
+#ifdef LED_ACTIVE_LOW
-    digitalWrite(HAS_TWO_LED, HIGH);
+      digitalWrite(HAS_TWO_LED, HIGH);
 #else
-    digitalWrite(HAS_TWO_LED, LOW);
+      digitalWrite(HAS_TWO_LED, LOW);
+#endif
+    }
 #endif
   }
 #endif // HAS_TWO_LED
 }
 
-void blink_LED(uint16_t set_color, uint16_t set_blinkduration) {
-#if (HAS_LED != NOT_A_PIN) || defined(HAS_RGB_LED)
-  LEDColor = set_color;                 // set color for RGB LED
-  LEDBlinkDuration = set_blinkduration; // duration
-  LEDBlinkStarted = millis();           // Time Start here
-  LEDState = LED_ON;                    // Let main set LED on
-#endif
-}
-
 #if (HAS_LED != NOT_A_PIN) || defined(HAS_RGB_LED)
 
 void ledLoop(void *parameter) {
@@ -151,7 +104,9 @@ void ledLoop(void *parameter) {
         LEDState = LED_OFF;
         LEDBlinkStarted = 0;
         LEDBlinkDuration = 0;
-        LEDColor = COLOR_NONE;
+#ifdef HAS_RGB_LED
+        led_setcolor(CRGB::Black);
+#endif
       } else {
         // In case of LoRaWAN led management blinked off
         LEDState = LED_ON;
@@ -161,7 +116,9 @@ void ledLoop(void *parameter) {
 #if (HAS_LORA)
       // LED indicators for viusalizing LoRaWAN state
       if (LMIC.opmode & (OP_JOINING | OP_REJOIN)) {
-        LEDColor = COLOR_YELLOW;
+#ifdef HAS_RGB_LED
+        led_setcolor(CRGB::Yellow);
+#endif
         // quick blink 20ms on each 1/5 second
         LEDState =
             ((millis() % 200) < 20) ? LED_ON : LED_OFF; // TX data pending
@@ -169,13 +126,19 @@ void ledLoop(void *parameter) {
         // select color to blink by message port
         switch (LMIC.pendTxPort) {
         case STATUSPORT:
-          LEDColor = COLOR_PINK;
+#ifdef HAS_RGB_LED
+          led_setcolor(CRGB::Pink);
+#endif
           break;
         case CONFIGPORT:
-          LEDColor = COLOR_CYAN;
+#ifdef HAS_RGB_LED
+          led_setcolor(CRGB::Cyan);
+#endif
           break;
         default:
-          LEDColor = COLOR_BLUE;
+#ifdef HAS_RGB_LED
+          led_setcolor(CRGB::Blue);
+#endif
           break;
         }
         // small blink 10ms on each 1/2sec (not when joining)
@@ -183,33 +146,25 @@ void ledLoop(void *parameter) {
         // This should not happen so indicate a problem
       } else if (LMIC.opmode &
                  ((OP_TXDATA | OP_TXRXPEND | OP_JOINING | OP_REJOIN) == 0)) {
-        LEDColor = COLOR_RED;
+#ifdef HAS_RGB_LED
+        led_setcolor(CRGB::Red);
+#endif
         // heartbeat long blink 200ms on each 2 seconds
         LEDState = ((millis() % 2000) < 200) ? LED_ON : LED_OFF;
       } else
+#elif (defined(HAS_RGB_LED) && ((WIFICOUNTER) || (BLECOUNTER)))
+      struct count_payload_t count;
+      libpax_counter_count(&count);
+      led_sethue(count.pax);
 #endif // HAS_LORA
       {
         // led off
-        LEDColor = COLOR_NONE;
         LEDState = LED_OFF;
       }
     }
-    // led need to change state? avoid digitalWrite() for nothing
+
-    if (LEDState != previousLEDState) {
+    switch_LED(LEDState);
-      if (LEDState == LED_ON) {
+
-        rgb_set_color(LEDColor);
-        // if we have only single LED we use it to blink for status
-#ifndef HAS_RGB_LED
-        switch_LED(LED_ON);
-#endif
-      } else {
-        rgb_set_color(COLOR_NONE);
-#ifndef HAS_RGB_LED
-        switch_LED(LED_OFF);
-#endif
-      }
-      previousLEDState = LEDState;
-    }
     // give yield to CPU
     delay(5);
   } // while(1)