From 0a510a0c33b64ef360a43d4e01a5fc0d3f1440f0 Mon Sep 17 00:00:00 2001
From: Oliver Seiler <oliver@seiler.kiwi>
Date: Tue, 29 Sep 2020 18:59:53 +1300
Subject: [PATCH] Improved time synch handling for GPS based time

This will update the time from GPS on first valid time received by GPS.
---
 src/gpsread.cpp    | 16 ++++------------
 src/main.cpp       |  5 -----
 src/timekeeper.cpp | 12 +++++-------
 3 files changed, 9 insertions(+), 24 deletions(-)

diff --git a/src/gpsread.cpp b/src/gpsread.cpp
index 650c5866..78683b7a 100644
--- a/src/gpsread.cpp
+++ b/src/gpsread.cpp
@@ -21,9 +21,6 @@ static uint16_t nmea_txDelay_ms =
 static uint16_t nmea_txDelay_ms = 0;
 #endif
 
-// did the last packet contain a valid time?
-bool hasValidTime = false;
-
 // initialize and configure GPS
 int gps_init(void) {
 
@@ -163,16 +160,11 @@ void gps_loop(void *pvParameters) {
       }
 #endif
 
-#if !TIME_SYNC_LORASERVER && !TIME_SYNC_LORAWAN
-      if (!hasValidTime) {
-        if (gpstime.isUpdated() && gpstime.isValid()) {
-          hasValidTime = true;
-          if (timeSource == _unsynced) {
-            calibrateTime();
-          }
-        }
+      // if time hasn't been synchronised yet, and we have a valid GPS time,
+      // update time from GPS.
+      if (timeSource == _unsynced && gpstime.isUpdated() && gpstime.isValid()) {
+        calibrateTime();
       }
-#endif
 
     } // if
 
diff --git a/src/main.cpp b/src/main.cpp
index e7b497c7..175e78f0 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -488,11 +488,6 @@ void setup() {
 #warning you did not specify a time source, time will not be synched
 #endif
 
-// initialize gps time
-#if (HAS_GPS)
-  get_gpstime();
-#endif
-
 #if (defined HAS_IF482 || defined HAS_DCF77)
   ESP_LOGI(TAG, "Starting Clock Controller...");
   clock_init();
diff --git a/src/timekeeper.cpp b/src/timekeeper.cpp
index 01777be7..0dba7caa 100644
--- a/src/timekeeper.cpp
+++ b/src/timekeeper.cpp
@@ -32,7 +32,7 @@ void calibrateTime(void) {
   uint16_t t_msec = 0;
 
   // kick off asychronous lora timesync if we have
-#if (HAS_LORA) && (TIME_SYNC_LORASERVER) || (TIME_SYNC_LORAWAN)
+#if (HAS_LORA) && ((TIME_SYNC_LORASERVER) || (TIME_SYNC_LORAWAN))
   timesync_request();
 #endif
 
@@ -44,19 +44,17 @@ void calibrateTime(void) {
 // has RTC -> fallback to RTC time
 #ifdef HAS_RTC
     t = get_rtctime();
-    timeSource = _rtc;
+    // set time from RTC
+    setMyTime((uint32_t)t, t_msec, _rtc);
 #endif
 
 // no RTC -> fallback to GPS time
 #if (HAS_GPS)
     t = get_gpstime(&t_msec);
-    if (t) {
-      timeSource = _gps;
-    }
+    // set time from GPS - method will check if time is valid
+    setMyTime((uint32_t)t, t_msec, _gps);
 #endif
 
-    setMyTime((uint32_t)t, t_msec, timeSource); // set time
-
   } // fallback
 
   else